feat: implement CreateSecret and DeleteSecret operations

[michaelsauter]

Closes #33.

I need this for the E2E tests of the External Secrets operator. My change is as minimal as possible, without touching e.g. TestSecret, though this may benefit from refactoring now that secrets can be created programmatically.

[michaelsauter]

FYI I added 7fc6b7d to make the tests pass as a whole. Otherwise each test needs to run in isolation and requires cleanup in the vault. Let me know if you are fine with this direction or would like to go a different route.

[michaelsauter]

@andrii-zakurenyi @sheldonhull How can I help move this forward?

[andrii-zakurenyi]

LGTM 👍
@sheldonhull please review and help with merging this change

[sheldonhull]

• Please update from main as I pushed an update to add integration tags to the files as they integrate with the target dsv server and aren't purely local.
• run trunk fmt and push (devcontainer included in project that sets that up automatically if you want). I tried to push those through but forgot it was a PR from a fork 😆
• This won't tag a release, as this requires a change entry (we use changie), but I'll be glad to do that after merging to main so you don't have to do it.

[michaelsauter]

• Please update from main as I pushed an update to add integration tags to the files as they integrate with the target dsv server and aren't purely local.
• run trunk fmt and push (devcontainer included in project that sets that up automatically if you want). I tried to push those through but forgot it was a PR from a fork 😆
• This won't tag a release, as this requires a change entry (we use changie), but I'll be glad to do that after merging to main so you don't have to do it.

Sounds good. I updated this PR accordingly.

[andrii-zakurenyi]

LGTM 👍

[sheldonhull]

I have to fix the test so might need one more update from main after I do this. Pretty sure it’s just a CI issue not a test failure. Cheers

[sheldonhull]

Haven’t forgotten about this. Thanks for your patience 🙏

[sheldonhull]

Ok, since this won't trigger the release, I'm going to merge since the test is passing now. The test failure originally was due to upstream github action changing. It's now pinned to prevent that.

We test with go 1.20.3 (see .aqua/aqua.yaml for the go version setup in tests.
The failing lint conditions were the init I mentioned before. This can be changed apart from the PR to avoid blocking it.
The other was usage of rand not aligning with gosec for security.
Since this is used for tests, it's ok to bypass and we can update the .golangci-lint.yaml file to exclude that if needed in the future.

@michaelsauter thanks for your contribution, it's really appreciated. Thanks also for your patience 👍🏻

[michaelsauter]

Thanks!

Do you have an estimate when you will be able to cut a release? And is there anything I can help with to make it happen? Asking because I want to move external-secrets/external-secrets#2415 forward :)

[sheldonhull]

Thanks!

Do you have an estimate when you will be able to cut a release? And is there anything I can help with to make it happen? Asking because I want to move external-secrets/external-secrets#2415 forward :)

just knocked it out: release. Cheers.