-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement CreateSecret and DeleteSecret operations #35
feat: implement CreateSecret and DeleteSecret operations #35
Conversation
FYI I added 7fc6b7d to make the tests pass as a whole. Otherwise each test needs to run in isolation and requires cleanup in the vault. Let me know if you are fine with this direction or would like to go a different route. |
@andrii-zakurenyi @sheldonhull How can I help move this forward? |
LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please update from
main
as I pushed an update to add integration tags to the files as they integrate with the target dsv server and aren't purely local. - run trunk fmt and push (devcontainer included in project that sets that up automatically if you want). I tried to push those through but forgot it was a PR from a fork 😆
- This won't tag a release, as this requires a change entry (we use changie), but I'll be glad to do that after merging to main so you don't have to do it.
Documentation and tests try to align to : as the seperator for DSV.
fd6a2a9
to
42cddf3
Compare
Sounds good. I updated this PR accordingly. |
LGTM 👍 |
ab1d8e8
to
42cddf3
Compare
I have to fix the test so might need one more update from main after I do this. Pretty sure it’s just a CI issue not a test failure. Cheers |
Haven’t forgotten about this. Thanks for your patience 🙏 |
Ok, since this won't trigger the release, I'm going to merge since the test is passing now. The test failure originally was due to upstream github action changing. It's now pinned to prevent that. We test with go 1.20.3 (see @michaelsauter thanks for your contribution, it's really appreciated. Thanks also for your patience 👍🏻 |
Thanks! Do you have an estimate when you will be able to cut a release? And is there anything I can help with to make it happen? Asking because I want to move external-secrets/external-secrets#2415 forward :) |
just knocked it out: release. Cheers. |
Closes #33.
I need this for the E2E tests of the External Secrets operator. My change is as minimal as possible, without touching e.g.
TestSecret
, though this may benefit from refactoring now that secrets can be created programmatically.