Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security(snyk): removed high level snyk issues for hard coded credentials #168

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

pacificcode
Copy link
Contributor

removed high level snyk issues for hard coded credentials

@pacificcode pacificcode requested a review from a team as a code owner August 12, 2024 20:21
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.05%. Comparing base (a2521eb) to head (cc83a6b).
Report is 116 commits behind head on main.

Files Patch % Lines
commands/cli-config.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #168       +/-   ##
===========================================
+ Coverage   32.61%   51.05%   +18.44%     
===========================================
  Files          80       87        +7     
  Lines       10855    11983     +1128     
===========================================
+ Hits         3540     6118     +2578     
+ Misses       7027     5565     -1462     
- Partials      288      300       +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ changie entry was found

Copy link
Contributor

github-actions bot commented Aug 15, 2024

✅ changie entry was found

constants/commands.go Show resolved Hide resolved
.changes/unreleased/security-20240812-133345.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ changie entry was found

Copy link
Contributor

@andrii-zakurenyi andrii-zakurenyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for snyk, bad for the codebase, but I get it and have no ideas on how to resolve it in a better way :)

@pacificcode
Copy link
Contributor Author

@andrii-zakurenyi I totally agree.

@pacificcode pacificcode merged commit 83f5a11 into main Aug 15, 2024
14 checks passed
@pacificcode pacificcode deleted the bh.hc.credentials branch August 15, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants