Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Too many NT publishers error if getting sim state for many steps #104. #105

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

brettle
Copy link
Member

@brettle brettle commented Jul 10, 2024

Fix #104

@brettle brettle requested a review from a team as a code owner July 10, 2024 17:08
@brettle brettle enabled auto-merge July 10, 2024 17:08
@CoolSpy3 CoolSpy3 disabled auto-merge July 13, 2024 01:10
@CoolSpy3 CoolSpy3 enabled auto-merge July 13, 2024 01:13
@CoolSpy3 CoolSpy3 merged commit 5807f88 into master Jul 13, 2024
3 checks passed
@CoolSpy3 CoolSpy3 deleted the fix-Watcher-not-reusing-publishers branch July 13, 2024 01:14
@CoolSpy3
Copy link
Member

I did some quick investigation into the build failure. This issue states that it's probably a result of something calling System.exit(). Our code doesn't do that, and the code does build locally, so I'm not going to block merging, but we can keep an eye out and see if it happens again in the future.

@brettle
Copy link
Member Author

brettle commented Jul 13, 2024

Here's the CI log. The "Connection reset by peer" is consistent with some process exiting unexpectedly. Since we don't call System.exit(), I suspect the JVM is crashing, possibly due to a bug in native WPIlib code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many NT publishers error if getting sim state for many steps
2 participants