Predict on fused model #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louis-Dupont
requested review from
shaydeci,
ofrimasad and
BloodAxe
as code owners
Louis-Dupont
commented
May 14, 2023
Louis-Dupont
commented
May 14, 2023
src/super_gradients/training/models/detection_models/customizable_detector.py
Outdated
Show resolved
Hide resolved
Louis-Dupont
commented
May 14, 2023
src/super_gradients/training/models/detection_models/pp_yolo_e/pp_yolo_e.py
Show resolved
Hide resolved
shaydeci
requested changes
May 14, 2023
src/super_gradients/training/models/detection_models/customizable_detector.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/models/detection_models/pp_yolo_e/pp_yolo_e.py
Show resolved
Hide resolved
shaydeci
requested changes
May 16, 2023
BloodAxe
reviewed
May 16, 2023
src/super_gradients/training/models/detection_models/customizable_detector.py
Show resolved
Hide resolved
BloodAxe
reviewed
May 16, 2023
BloodAxe
reviewed
May 16, 2023
avideci
pushed a commit
that referenced
this pull request
May 23, 2023
* predict on fused model * working version * fix * update * update * add benchmarl * add reset * torch.from_numpy * fix
avideci
pushed a commit
that referenced
this pull request
May 23, 2023
* predict on fused model * working version * fix * update * update * add benchmarl * add reset * torch.from_numpy * fix
geoffrey-g-delhomme
pushed a commit
to geoffrey-g-delhomme/super-gradients
that referenced
this pull request
May 26, 2023
* predict on fused model * working version * fix * update * update * add benchmarl * add reset * torch.from_numpy * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually, I took the fused model out of the SgModule to move it to the pipeline, which makes more sense and simplifies the code.
I also added cache with
lru_cacheto solve the issue of knowing when the pipeline needs to be instantiated or not.