Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty mask in MaskAttentionLoss #982

Merged
merged 3 commits into from
May 11, 2023
Merged

Fix empty mask in MaskAttentionLoss #982

merged 3 commits into from
May 11, 2023

Conversation

lkdci
Copy link
Contributor

@lkdci lkdci commented May 11, 2023

Fix case where MaskAttentionLoss return nan values when the input mask is empty. Reported in #912

Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkdci lkdci merged commit f5cfccc into master May 11, 2023
@lkdci lkdci deleted the bugfix/SG-862_empty_mask branch May 11, 2023 20:08
avideci pushed a commit that referenced this pull request May 23, 2023
avideci pushed a commit that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants