Bug/sg 764 wrong ckpt when resuming with external ckpt root dir #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaydeci
requested review from
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
Louis-Dupont
reviewed
May 8, 2023
Louis-Dupont
reviewed
May 8, 2023
src/super_gradients/common/environment/checkpoints_dir_utils.py
Outdated
Show resolved
Hide resolved
shaydeci
deleted the
bug/SG-764_wrong_ckpt_when_resuming_with_external_ckpt_root_dir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we dont pass ckpt_root_dir (till now) to get_checkpoints_dir_path it takes by default the pkg_resources one. Then if someone calls train with training_hyperparams.resume=True ckpt_root_dir=/some/path/to/ckpt_root/ we discard the ckpt_root_dir and get that we are trying to load a checkpoint that does not exist.