Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 850 support torch 2.0 #944

Merged
merged 12 commits into from
May 8, 2023
Merged

Conversation

shaydeci
Copy link
Collaborator

@shaydeci shaydeci commented May 7, 2023

  • Fixed some failing tests in build after moving it to run on 3.8.
  • Moved build to run on 3.8 (minimum python version requirement for torch 2.0)
  • Fixed missing arch_params.num classes that were missing for pose estimation regression test.
  • Updated requirement, pip version in CI.

@dagshub
Copy link

dagshub bot commented May 7, 2023

@shaydeci shaydeci marked this pull request as ready for review May 7, 2023 12:19
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see a few questions before merge

@shaydeci shaydeci merged commit b9fdd0e into master May 8, 2023
@shaydeci shaydeci deleted the feature/SG-850_check_torch_20 branch May 8, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants