Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecate -> deprecated #906

Merged

Conversation

BloodAxe
Copy link
Collaborator

@BloodAxe BloodAxe commented May 4, 2023

This small PR fixes wrong import of deprecate package that we do not declare in our requirements.
Instead we use deprecated. So I changed that. The motivation for this fix is when we loose some of our requirements, the deprecated package is not installed anymore and we get import error because of that.

@dagshub
Copy link

dagshub bot commented May 4, 2023

Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 56a5465 into master May 4, 2023
@BloodAxe BloodAxe deleted the feature/SG-000-fix-deprecate-vs-deprecated-mismatch branch May 4, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants