Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support single output in YoloX nms #813

Merged
merged 9 commits into from
Jul 5, 2023

Conversation

lkdci
Copy link
Contributor

@lkdci lkdci commented Apr 2, 2023

No description provided.

@dagshub
Copy link

dagshub bot commented Apr 2, 2023

lkdci added 2 commits May 14, 2023 17:46
…nto feature/ALG-1294_yolox_nms_single_pred

� Conflicts:
�	src/super_gradients/training/models/detection_models/yolo_base.py
@lkdci
Copy link
Contributor Author

lkdci commented May 14, 2023

@BloodAxe Added unit tests with yolox output and mock model outputs. I will appreciate your re-review

@lkdci lkdci requested a review from BloodAxe May 14, 2023 15:28
@shaydeci
Copy link
Collaborator

@lkdci @BloodAxe This PR has been open for quite a while now. It has comments that haven't been resolved yet and conflicts.
Please fix and re-review.

…nto feature/ALG-1294_yolox_nms_single_pred

� Conflicts:
�	tests/deci_core_unit_test_suite_runner.py
@lkdci
Copy link
Contributor Author

lkdci commented Jun 11, 2023

@BloodAxe @shaydeci , conflicts resolved. As mentioned above review was addressed, I'll appreciate your re-review of the fixes

ofrimasad
ofrimasad previously approved these changes Jul 5, 2023
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit d745265 into master Jul 5, 2023
6 checks passed
@ofrimasad ofrimasad deleted the feature/ALG-1294_yolox_nms_single_pred branch July 5, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants