Segformer model and recipe #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eran-deci
requested review from
shaydeci,
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
BloodAxe
reviewed
Feb 28, 2023
src/super_gradients/training/models/segmentation_models/segformer.py
Outdated
Show resolved
Hide resolved
BloodAxe
reviewed
Feb 28, 2023
src/super_gradients/training/models/segmentation_models/segformer.py
Outdated
Show resolved
Hide resolved
BloodAxe
reviewed
Feb 28, 2023
src/super_gradients/training/models/segmentation_models/segformer.py
Outdated
Show resolved
Hide resolved
BloodAxe
reviewed
Feb 28, 2023
src/super_gradients/recipes/dataset_params/cityscapes_segformer_dataset_params.yaml
Show resolved
Hide resolved
…AI/super-gradients into segformer_model_and_recipe
|
Hi @eran-deci do you mind updating the PR to make the build passing? Looks like there is only black formatting that is left |
ofrimasad
reviewed
Mar 12, 2023
There was a problem hiding this comment.
Very nice work.
Was this code taken from the original repo or another repo?
please make sure the code has Apache/BSD/MIT license
My comments are inline. we will fix some more general SG related comment in the future (just add the # TODO in the required places)
src/super_gradients/training/models/segmentation_models/segformer.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/models/segmentation_models/segformer.py
Outdated
Show resolved
Hide resolved
…AI/super-gradients into segformer_model_and_recipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.