-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation on using configuration files #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last thing inline...
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* first draft * wip * fix master installation * rename file * fix * fix comment
* first draft * wip * fix master installation * rename file * fix * fix comment
* add log readme * rename logs * wip * add other files to the platform callback * documentation on using configuration files (#661) * first draft * wip * fix master installation * rename file * fix * fix comment * multi gpu mode explicitly mentioned (#665) * Hotfix/sg 000 fix regression tests (#666) * multi gpu mode explicitly mentioned * tests reordered * rename logs * add upload of hydra * add required content for logs and add env variable * add summary and hydra * small change * fix logging --------- Co-authored-by: Ofri Masad <ofrimasad@users.noreply.github.com> Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
* wip * first draft * wip * documentation on using configuration files (#661) * first draft * wip * fix master installation * rename file * fix * fix comment * multi gpu mode explicitly mentioned (#665) * Hotfix/sg 000 fix regression tests (#666) * multi gpu mode explicitly mentioned * tests reordered * add some comments to setup_device * small fixes and rename * small typo fix * fix typos --------- Co-authored-by: Ofri Masad <ofrimasad@users.noreply.github.com> Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
No description provided.