Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation on using configuration files #661

Merged
merged 9 commits into from
Jan 29, 2023

Conversation

ofrimasad
Copy link
Collaborator

No description provided.

@dagshub
Copy link

dagshub bot commented Jan 29, 2023

Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions inline.

documentation/source/configuration_files.md Show resolved Hide resolved
documentation/source/configuration_files.md Show resolved Hide resolved
documentation/source/configuration_files.md Show resolved Hide resolved
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last thing inline...

documentation/source/configuration_files.md Show resolved Hide resolved
@ofrimasad
Copy link
Collaborator Author

fixed

Copy link
Collaborator Author

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

documentation/source/configuration_files.md Show resolved Hide resolved
documentation/source/configuration_files.md Show resolved Hide resolved
documentation/source/configuration_files.md Show resolved Hide resolved
documentation/source/configuration_files.md Show resolved Hide resolved
documentation/source/configuration_files.md Show resolved Hide resolved
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit f1e22b7 into master Jan 29, 2023
@shaydeci shaydeci deleted the feature/SG-608_configuration_files branch January 29, 2023 15:43
Louis-Dupont pushed a commit that referenced this pull request Jan 30, 2023
* first draft

* wip

* fix master installation

* rename file

* fix

* fix comment
Louis-Dupont pushed a commit that referenced this pull request Jan 30, 2023
* first draft

* wip

* fix master installation

* rename file

* fix

* fix comment
shaydeci added a commit that referenced this pull request Feb 1, 2023
* add log readme

* rename logs

* wip

* add other files to the platform callback

* documentation on using configuration files (#661)

* first draft

* wip

* fix master installation

* rename file

* fix

* fix comment

* multi gpu mode explicitly mentioned (#665)

* Hotfix/sg 000 fix regression tests (#666)

* multi gpu mode explicitly mentioned

* tests reordered

* rename logs

* add upload of hydra

* add required content for logs and add env variable

* add summary and hydra

* small change

* fix logging

---------

Co-authored-by: Ofri Masad <ofrimasad@users.noreply.github.com>
Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
ofrimasad added a commit that referenced this pull request Feb 1, 2023
* wip

* first draft

* wip

* documentation on using configuration files (#661)

* first draft

* wip

* fix master installation

* rename file

* fix

* fix comment

* multi gpu mode explicitly mentioned (#665)

* Hotfix/sg 000 fix regression tests (#666)

* multi gpu mode explicitly mentioned

* tests reordered

* add some comments to setup_device

* small fixes and rename

* small typo fix

* fix typos

---------

Co-authored-by: Ofri Masad <ofrimasad@users.noreply.github.com>
Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants