Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 568 single epoch sanity test for all recipes #645

Merged
merged 29 commits into from
Jan 23, 2023
Merged

Feature/sg 568 single epoch sanity test for all recipes #645

merged 29 commits into from
Jan 23, 2023

Conversation

shaydeci
Copy link
Collaborator

@shaydeci shaydeci commented Jan 23, 2023 •
edited
Loading

  • Updated recipe configs of crashing recipes.
  • New jobs and workflows for each regression test by task.

@shaydeci
black
37e474e
@shaydeci
black on kdtrainer
ee97704
@shaydeci
Merge branch 'bug/SG-000_update_kd_train_from_config' into feature/SG…
fcd62af 
…-568_singel_epoch_sanity_test_for_all_recipes
@shaydeci
some comments in config
ae215a0
@shaydeci
all commands in test
e4c7fb1
@shaydeci
typo in call for test
10779f1
@shaydeci
wip
c7ee7c6
@shaydeci
pwd fix
556df60
@shaydeci
commented out coverage run
6fc6453
@shaydeci
batch size fix
d59507d
@shaydeci
typo
76e7f25
@shaydeci
switched between ddrnet tests
fcd557a
@shaydeci
avg best models= false
2245a3e
@shaydeci
typo found
b126789
@shaydeci
bb path fix
c1787ba
@shaydeci
train from kd typo fix
6f4ebe6
@shaydeci
paths typo
6f8b6f0
@shaydeci
black hook on path fix
4974da2
@shaydeci
coco ssdlite inheritance fix
c0acfc7
@shaydeci
Merge remote-tracking branch 'origin/master' into feature/SG-568_sing…
82b8fb4 
…el_epoch_sanity_test_for_all_recipes
@shaydeci
ssd test moved up and interpolation fixed
8262a5b
@shaydeci
wrong architectures in tests
69ad6ae
@shaydeci
all recipe tests together- final version before brining back release …
070ac57 
…tag filter
@shaydeci
tests divided into tasks
4b1b788
@dagshub
Copy link

dagshub bot commented Jan 23, 2023

Join the discussion on DagsHub!

@shaydeci shaydeci changed the title Feature/sg 568 singel epoch sanity test for all recipes Feature/sg 568 single epoch sanity test for all recipes Jan 23, 2023
@shaydeci shaydeci marked this pull request as ready for review January 23, 2023 09:36
ofrimasad
ofrimasad reviewed Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor questions.
IF we can shorten the path to the test script somehow, that would be great

src/super_gradients/recipes/coco2017_ssd_lite_mobilenet_v2.yaml Show resolved Hide resolved
src/super_gradients/recipes/coco_segmentation_shelfnet_lw.yaml Show resolved Hide resolved
ofrimasad
ofrimasad approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit c5e7d97 into master Jan 23, 2023
@ofrimasad ofrimasad deleted the feature/SG-568_singel_epoch_sanity_test_for_all_recipes branch January 23, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaydeci @ofrimasad