Skip CI on .md files - SG side #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es_sg_side' into feature/SG-585_skip_ci_on_md_files_sg_side
ranrubin
previously approved these changes
Jan 18, 2023
There was a problem hiding this comment.
looks good.
I suggest using yaml injection (I don't remember the actual name), instead of coping the environment every job
CIRCLE_COMPARE_URL: << pipeline.project.git_url >>/compare/<< pipeline.git.base_revision >>..<<pipeline.git.revision>>
What I mean is doing a similar thing to what we do with the branch filters.
…es_sg_side' into feature/SG-585_skip_ci_on_md_files_sg_side
…es_sg_side' into feature/SG-585_skip_ci_on_md_files_sg_side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.