Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 624 remove avg from model plots #629

Merged
merged 8 commits into from
Jan 19, 2023

Conversation

Louis-Dupont
Copy link
Contributor

Currently SG adds the average model at the end of the training graph.

For instance if we train on 300 epochs, at the end of the training SG adds the average model validation metric/loss to the graph, leading to 301 data points on validation plots (vs 300 on training plots).

This is also the case with EarlyStop callback: if trained on 40 epochs, the average model will be added and we will have 41 data points, and even worse: the last point will be displayed at index 300!

This is bad especially since this information is stored in a separate graph (of only 1 data point per training), so I guess we should just remove this behavior.

@dagshub
Copy link

dagshub bot commented Jan 17, 2023

@Louis-Dupont Louis-Dupont marked this pull request as ready for review January 17, 2023 10:02
@Louis-Dupont Louis-Dupont marked this pull request as draft January 18, 2023 09:21
@Louis-Dupont Louis-Dupont marked this pull request as ready for review January 18, 2023 09:22
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit 5f485ad into master Jan 19, 2023
@Louis-Dupont Louis-Dupont deleted the feature/SG-624-remove_avg_from_model_graphs branch January 19, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants