Group env variables #618
Merged
Group env variables #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Dupont <louis-dupont@live.fr>
Louis-Dupont
force-pushed
the
feature/SG-586-group_env_variables
branch
from
3c81e1f
to
2e7cc70
Compare
shaydeci
requested changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are working with env variables but without any documentation/way to know which one, and where it is used.
I believe it is bad practice which makes the code harder to maintain (risk of duplicating existing env variables), but also to use (if I work on a new environment and want to setup everything, what env variable do I need to set ?).