Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 1.13 #603

Merged
merged 21 commits into from
Jan 19, 2023
Merged

Support 1.13 #603

merged 21 commits into from
Jan 19, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Jan 8, 2023

No description provided.

@dagshub
Copy link

dagshub bot commented Jan 8, 2023

@Louis-Dupont Louis-Dupont marked this pull request as ready for review January 8, 2023 09:43
shaydeci
shaydeci previously approved these changes Jan 8, 2023
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment inline. can we make

requirements.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set it to 1.13.*?

Louis-Dupont and others added 9 commits January 8, 2023 15:27
* New callbacks API

* New callbacks API

* New callbacks API

* Fix imports

* Uncomment sanity check

* Fix callbacks order

* Fix callbacks order

* Fix callbacks order

* Fix wrong import

* Fix wrong import

* Call update_context

* Call update_context

* Fix on_train_batch_start timing

* Added docs clarifying mapping of new events to old Phase enum values

* Instantiate context after _prep_for_test

Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
* first version - a few things to change

* improve

* imrpove doc

* undo requirements change

* mini update

* support wildcards and improve code

* move all to same file, and only raise error when version too small

* move all to same file, and only raise error when version too small

* remove arg
ofrimasad
ofrimasad previously approved these changes Jan 18, 2023
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit 1454f8e into master Jan 19, 2023
@Louis-Dupont Louis-Dupont deleted the feature/SG-489-torch_1.13 branch January 19, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants