Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 521 gpu tests #587

Merged
merged 74 commits into from
Dec 29, 2022
Merged

Feature/sg 521 gpu tests #587

merged 74 commits into from
Dec 29, 2022

Conversation

shaydeci
Copy link
Collaborator

@shaydeci shaydeci commented Dec 28, 2022 •
edited
Loading

Added-

  • Recipe tests suite: currently contains tests running on saved checkpoints from the experiments ran in line 206 .circleci/config.yml . Main purpose is to test training generally works with DDP and the ran recipes metrics aren't stuck.
  • Small fix in SgTrainer (batch size warning for drop last- when using BatchSampler it failed since in that case there's no "batch_size" attribute).
  • Exit code for DDP exit set to 0 (was message before, which led to CI failing, and is not an informative exit code).
  • Numpy requirement which led to failure.

@shaydeci
workflow added
57c077d
@shaydeci
first tests added
077e43d
@shaydeci
sanity tests moved
0ef726a
@shaydeci
-m removed
7f5bf04
@shaydeci
env var added
bd0dc11
@shaydeci
installation from branch added
5e930d1
@shaydeci
more changes
933ab79
@shaydeci
command fix
a195d97
@shaydeci
formatt
5829e10
@shaydeci
remove env adde to recipe+tests
9b065d7
@shaydeci
Merge remote-tracking branch 'origin/master' into feature/SG-521_gpu_…
799c55c 
…tests
@shaydeci
command fix in config
6183ee3
@shaydeci
torchrun instead of python
567dcdf
@shaydeci
command update
35a1b38
@shaydeci
hydra full error env var
6d4ca53
@shaydeci
train from recipe cmd
6e7a7f0
@shaydeci
torch installation fix
d084309
@shaydeci
protobuf version try
e06eabe
@shaydeci
lets get this running
f5c6a11
@shaydeci
lets get this working
1ffd2bb
@shaydeci
let make this work2
422de1f
@shaydeci
lets make this work 3.0
27f866b
@shaydeci
let make this work 4.0
6adf90f
@shaydeci
Merge remote-tracking branch 'origin/master' into feature/SG-521_gpu_…
f7f8beb 
…tests
@shaydeci
lets make this work 5.0
ea7c9a5
@shaydeci
coco try
f63bd60
@shaydeci
coco try yolox
04d9528
@shaydeci
coco try yolox fix num gpus
38cd95f
@shaydeci
reordr installs
92931e7
@shaydeci
order installs + python3.8 removed
4e2fca2
@dagshub
Copy link

dagshub bot commented Dec 28, 2022

Join the discussion on DagsHub!

@shaydeci shaydeci marked this pull request as ready for review December 28, 2022 09:49
ofrimasad
ofrimasad reviewed Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments inline

.circleci/config.yml Show resolved Hide resolved
src/super_gradients/training/sg_trainer/sg_trainer.py Show resolved Hide resolved
ofrimasad
ofrimasad approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit 9e24a33 into master Dec 29, 2022
@shaydeci shaydeci deleted the feature/SG-521_gpu_tests branch December 29, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaydeci @ofrimasad