Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compute_detection_metrics_per_cls return value when no detection … #583

Merged
merged 10 commits into from
Dec 25, 2022
Merged

fix compute_detection_metrics_per_cls return value when no detection … #583

merged 10 commits into from
Dec 25, 2022

Conversation

ofrimasad
Copy link
Collaborator

…in image.

added test

@dagshub
Copy link

dagshub bot commented Dec 20, 2022

Join the discussion on DagsHub!

shaydeci
shaydeci requested changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment inline.

tests/unit_tests/detection_utils_test.py Outdated Show resolved Hide resolved
shaydeci
shaydeci approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 14e2025 into master Dec 25, 2022
@ofrimasad ofrimasad deleted the feature/SG-452_fix_detection_per_metric branch December 25, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ofrimasad @shaydeci