Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

predict() support for segmentation models and more #1708

Merged
merged 31 commits into from
Dec 20, 2023
Merged

predict() support for segmentation models and more #1708

merged 31 commits into from
Dec 20, 2023

Conversation

BloodAxe
Copy link
Collaborator

@BloodAxe BloodAxe commented Dec 15, 2023 •
edited
Loading

Here we go again with predict() support for segmentation models.
What have I done on top of former PR:

  • Deprecated SegToTensor in favor of SegConvertToTensor. Old class disallow it's creation and raise an error to leave no options other than migrate. The SegToTensor was doing /255 and HWC->CHW which could cause many unwanted issues since /255 was performed only when input is byte dtype. There are many cases when image dtype can change unintentionally. Moreover, SegToTensor had to be applied first and only after SegNormalize. And it was breaking preprocessing in predict().
  • Introduce SegStandardize
  • Add missing default preprocessing params for other segmentation models
  • Improves visualization of segmentation mask when the task is binary segmentation
  • Implement missing methods across the segmentation transforms
  • All recipes updated to use SegConvertToTensor
  • SegmentationSample will convert PIL image under the hood to np.ndarray and Segmentaiton transforms will not return PIL image anymore

dafna-r and others added 18 commits August 10, 2023 17:21
@dafna-r
squashed commits from segmentation predict branch
666d46d
@BloodAxe
Set ignore_errors=True to trainer test and declare why
7e05f22
@dafna-r
Merge branch 'master' into features/SG-000-predict_segmentation_signed
05bdb92
@Louis-Dupont
Merge branch 'master' into features/SG-000-predict_segmentation_signed
de49255
@shaydeci @BloodAxe @Louis-Dupont
version bumped (#1374)
054603c 
Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
@Louis-Dupont
Merge branch 'master' into features/SG-000-predict_segmentation_signed
773cf10
@Louis-Dupont
Merge branch 'master' into features/SG-000-predict_segmentation_signed
7da5815
@dafna-r
segmentation predict:
4e37aff 
remove predict from ppliteseg models (PPLiteSegBase) as it's implement in SegmentationModule
@dafna-r
Merge remote-tracking branch 'origin/features/SG-000-predict_segmenta…
1a0b4f1 
…tion_signed' into features/SG-000-predict_segmentation_signed
@BloodAxe
Merge branch 'master' into features/SG-000-predict_segmentation_signed
7ad3c78
@shaydeci
Merge branch 'master' into features/SG-000-predict_segmentation_signed
2daa38c
@BloodAxe
Merge branch 'master' into features/SG-000-predict_segmentation_signed
94770d0
@BloodAxe
Merge remote-tracking branch 'origin/master' into features/SG-000-pre…
16dcde7 
…dict_segmentation_signed
@BloodAxe
Merge branch 'master' into features/SG-000-predict_segmentation_signed
8983ada 
# Conflicts:
#	src/super_gradients/training/datasets/segmentation_datasets/segmentation_dataset.py
#	src/super_gradients/training/processing/processing.py
#	src/super_gradients/training/transforms/utils.py
#	tests/unit_tests/test_predict.py
@BloodAxe
Added missing transforms in validation
1dc2a39
@BloodAxe
Add missing default preprocessing params for rest of the models
3ce642e
@BloodAxe
Add STDC predict
ce63e2f
@BloodAxe
Update the predict & transforms & deprecate SegToTensor
7d5821f
@BloodAxe BloodAxe marked this pull request as ready for review December 15, 2023 20:51
ofrimasad
ofrimasad reviewed Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
a few minor comments.
Does this support long video (like the new implementation in object detection)?

src/super_gradients/common/object_names.py Show resolved Hide resolved
src/super_gradients/examples/predict/segmentation_predict.py Outdated Show resolved Hide resolved
src/super_gradients/training/models/segmentation_models/segmentation_module.py Show resolved Hide resolved
src/super_gradients/training/models/segmentation_models/stdc.py Show resolved Hide resolved
src/super_gradients/training/pipelines/pipelines.py Show resolved Hide resolved
src/super_gradients/training/pipelines/pipelines.py Show resolved Hide resolved
@BloodAxe
Copy link
Collaborator Author

Very nice! a few minor comments. Does this support long video (like the new implementation in object detection)?

Yes, the way video prediction is implemented is actually pretty nice since all the tasks support long video processing automatically.

Louis-Dupont
Louis-Dupont reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor notes

src/super_gradients/examples/predict/segmentation_predict.py Show resolved Hide resolved
src/super_gradients/training/processing/processing.py Show resolved Hide resolved
src/super_gradients/training/processing/processing.py Outdated Show resolved Hide resolved
Louis-Dupont
Louis-Dupont approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit c4bbce7 into master Dec 20, 2023
6 of 7 checks passed
@BloodAxe BloodAxe deleted the features/SG-000-predict_segmentation_signed branch December 20, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad left review comments

@Louis-Dupont Louis-Dupont Louis-Dupont approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci shaydeci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BloodAxe @ofrimasad @Louis-Dupont @dafna-r @shaydeci