Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 1277 depth estimation dataset support #1705

Merged
merged 21 commits into from
Dec 19, 2023

Conversation

shaydeci
Copy link
Collaborator

  • Base class for depth estimation dataset.
  • NYUv2 Depth Estimaiton dataset class + subset of examples for testing.
  • DepthEstimationSample + PipelineAdapteor support for it.
  • Unit tests and Albumentations integration test.

@shaydeci shaydeci changed the title Feature/sg 1277 depth estimation data Feature/sg 1277 depth estimation dataset support Dec 14, 2023
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice.
a few minor comments

Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit 1588612 into master Dec 19, 2023
7 checks passed
@shaydeci shaydeci deleted the feature/SG-1277_depth_estimation_data branch December 19, 2023 13:30
Louis-Dupont pushed a commit that referenced this pull request Dec 19, 2023
* added sample, datasets and transforms

* added docsand instructions to dataset

* dataset examples and imports

* added plot

* pipeline adaptor for albu added

* added albu test

* modified object names to be more clear

* removed apply transform

* added depth visualization

* minor improvements for visualization module

* fixed getitem returning sample

* fixed getitem return type

* fixed getitem redundant clipping

* fixed plot ignore

* fixed unit test

* added clarifications in getitem and load_sample

* updated plot()

* updated casting image to fp32
BloodAxe added a commit that referenced this pull request Dec 21, 2023
* all code squashed

* add to Makefile and update Readme

* remove ppritn and fix pip install

* update with all cell outputs

* Feature/sg 1277 depth estimation dataset support (#1705)

* added sample, datasets and transforms

* added docsand instructions to dataset

* dataset examples and imports

* added plot

* pipeline adaptor for albu added

* added albu test

* modified object names to be more clear

* removed apply transform

* added depth visualization

* minor improvements for visualization module

* fixed getitem returning sample

* fixed getitem return type

* fixed getitem redundant clipping

* fixed plot ignore

* fixed unit test

* added clarifications in getitem and load_sample

* updated plot()

* updated casting image to fp32

* update notebook to 3.5

---------

Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants