-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sg 1277 depth estimation dataset support #1705
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shaydeci
commented
Dec 14, 2023
- Base class for depth estimation dataset.
- NYUv2 Depth Estimaiton dataset class + subset of examples for testing.
- DepthEstimationSample + PipelineAdapteor support for it.
- Unit tests and Albumentations integration test.
…th_estimation_data
shaydeci
requested review from
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
December 14, 2023 09:27
shaydeci
changed the title
Feature/sg 1277 depth estimation data
Feature/sg 1277 depth estimation dataset support
Dec 14, 2023
BloodAxe
reviewed
Dec 14, 2023
ofrimasad
reviewed
Dec 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice.
a few minor comments
...r_gradients/training/datasets/depth_estimation_datasets/abstract_depth_estimation_dataset.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/depth_estimation/abstract_depth_estimation_transform.py
Show resolved
Hide resolved
BloodAxe
reviewed
Dec 18, 2023
...r_gradients/training/datasets/depth_estimation_datasets/abstract_depth_estimation_dataset.py
Outdated
Show resolved
Hide resolved
BloodAxe
reviewed
Dec 18, 2023
src/super_gradients/training/utils/visualization/depth_estimation.py
Outdated
Show resolved
Hide resolved
BloodAxe
reviewed
Dec 18, 2023
src/super_gradients/training/utils/visualization/depth_estimation.py
Outdated
Show resolved
Hide resolved
BloodAxe
reviewed
Dec 18, 2023
src/super_gradients/training/utils/visualization/depth_estimation.py
Outdated
Show resolved
Hide resolved
BloodAxe
reviewed
Dec 18, 2023
src/super_gradients/training/utils/visualization/depth_estimation.py
Outdated
Show resolved
Hide resolved
BloodAxe
reviewed
Dec 18, 2023
...r_gradients/training/datasets/depth_estimation_datasets/abstract_depth_estimation_dataset.py
Outdated
Show resolved
Hide resolved
BloodAxe
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Louis-Dupont
pushed a commit
that referenced
this pull request
Dec 19, 2023
* added sample, datasets and transforms * added docsand instructions to dataset * dataset examples and imports * added plot * pipeline adaptor for albu added * added albu test * modified object names to be more clear * removed apply transform * added depth visualization * minor improvements for visualization module * fixed getitem returning sample * fixed getitem return type * fixed getitem redundant clipping * fixed plot ignore * fixed unit test * added clarifications in getitem and load_sample * updated plot() * updated casting image to fp32
BloodAxe
added a commit
that referenced
this pull request
Dec 21, 2023
* all code squashed * add to Makefile and update Readme * remove ppritn and fix pip install * update with all cell outputs * Feature/sg 1277 depth estimation dataset support (#1705) * added sample, datasets and transforms * added docsand instructions to dataset * dataset examples and imports * added plot * pipeline adaptor for albu added * added albu test * modified object names to be more clear * removed apply transform * added depth visualization * minor improvements for visualization module * fixed getitem returning sample * fixed getitem return type * fixed getitem redundant clipping * fixed plot ignore * fixed unit test * added clarifications in getitem and load_sample * updated plot() * updated casting image to fp32 * update notebook to 3.5 --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com> Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.