Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_resize for model.predict #1605

Merged
merged 22 commits into from
Nov 13, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Nov 2, 2023

No description provided.

@Louis-Dupont Louis-Dupont marked this pull request as ready for review November 6, 2023 13:02
@BloodAxe
Copy link
Collaborator

BloodAxe commented Nov 8, 2023

Looking good!
I think what we also should add to this PR is updated docs on predict() that shows usage of this feature with a nice large image with a lot of small objects.

* Way to fix bug with validation frequency

* Fixed test, the state of net was rewritten

* Added validating the latest epoch and epochs from save_ckpt_epoch_list

* Added one more testcase to check wether latest notdivisible epoch has valid in metrics

* Following the SRP recommendation...

* Which inference time exactly

* Fixed incorrect keyword in writing function

* Missing brackets around epoch+1 in valid run check function.

* Final fixes hopefully :)

* Fixed trainer to add scalars only in main process

---------

Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
@Louis-Dupont Louis-Dupont changed the title Add skip_resize for mode.predict Add skip_resize for model.predict Nov 9, 2023
Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit a07f906 into master Nov 13, 2023
8 checks passed
@Louis-Dupont Louis-Dupont deleted the feature/SG-1146-add_skip_resize_in_predict branch November 13, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants