Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom dataset notebook #1592

Merged
merged 17 commits into from
Nov 14, 2023

Conversation

Louis-Dupont
Copy link
Contributor

No description provided.

@BloodAxe
Copy link
Collaborator

BloodAxe commented Nov 1, 2023

Pls update the install commands:

!pip install data-gradients==0.2.1 gwpy &> /dev/null
!pip install super-gradients==3.3.1 gwpy &> /dev/null
!pip freeze gwpy &> /dev/null

to

!pip install -qq super-gradients==3.3.1

(No need to specify DG version IMO since it's already in requirements)

@BloodAxe
Copy link
Collaborator

BloodAxe commented Nov 3, 2023

This #1607 should be merged before current PR

@Louis-Dupont
Copy link
Contributor Author

Changing pip install ... 873d4e9

@BloodAxe
Copy link
Collaborator

Just a minor comment on the notebook - we don't need prettyformatter as pprint comes with a standard python 3.x (from pprint import pprint) so this dependency can be dropped from pip install list.

Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 4931566 into master Nov 14, 2023
8 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1191-add_connect_custom_dataset_notebook branch November 14, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants