Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for DatasetAdapter #1591

Merged
merged 16 commits into from
Nov 13, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Oct 30, 2023

PR for Dataloader Adapter documentation.

The .md is generated from the notebook.

The notebook cannot be run automatically in tests because it requires user inputs.

@BloodAxe
Copy link
Collaborator

BloodAxe commented Nov 2, 2023

Pls update install instructions FROM

!pip install data-gradients==0.2.1 gwpy &> /dev/null
!pip install super-gradients==3.3.1 gwpy &> /dev/null
!pip freeze gwpy &> /dev/null

TO

!pip install -qq super-gradients==3.3.1

@BloodAxe
Copy link
Collaborator

BloodAxe commented Nov 3, 2023

This #1607 should be merged before current PR

@Louis-Dupont
Copy link
Contributor Author

pip install ... changed in ff78e13

@BloodAxe
Copy link
Collaborator

Please update the installed version of SG to latest 3.4.1:

!pip install -q super-gradients==3.3.1

Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 8e36fbe into master Nov 13, 2023
8 checks passed
@BloodAxe BloodAxe deleted the feature/SG-113-add_dataset_adapter_doc branch November 13, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants