Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 1190 transfer learning cls notebook #1587

Merged
merged 15 commits into from
Nov 2, 2023

Conversation

shaydeci
Copy link
Collaborator

No description provided.

@Louis-Dupont
Copy link
Contributor

I see that in the notebook there is no hard coded version. It's safer to hard code, to avoid having broken code

@BloodAxe
Copy link
Collaborator

!pip install -qq super_gradients==3.3.1 should be enough (Note -qq to silence non-important stuff)

@shaydeci
Copy link
Collaborator Author

@Louis-Dupont
@BloodAxe
Updated pip command with your suggestions

@BloodAxe
Copy link
Collaborator

BloodAxe commented Nov 1, 2023

Good, but I'm still not fully happy )

!!pip install -qq super_gradients==3.3.1
! pip install -qq matplotlib==3.1.3
! python -m pip install --upgrade pillow==9.2.0
  1. Double-exclamation mark? !!pip would work?
  2. We have matplotlib in our requirements. No need to re-install older version (We have matplotlib>=3.3.4)
  3. Same with Pillow, it was back in the day until we fixed this Pillow is_directory stuff, so now it should work outside the box

Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit 24102a8 into master Nov 2, 2023
8 checks passed
@shaydeci shaydeci deleted the feature/SG-1190_transfer_learning_cls_notebook branch November 2, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants