Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added recipe unifying script #1560

Merged
merged 20 commits into from
Oct 31, 2023
Merged

Added recipe unifying script #1560

merged 20 commits into from
Oct 31, 2023

Conversation

shaydeci
Copy link
Collaborator

@shaydeci shaydeci commented Oct 23, 2023 •
edited
Loading

Usage:

python merge_recipe --config_name=cifar10_resnet -> saves cifar10_resnet_complete.yaml in path/to/super_gradients/recipes

python merge_recipe --config_dir=/path/to/recipes/ config_name=my_recipe.yaml -> saves config_name_complete.yaml in /path/to/recipes/

python merge_recipe --config_dir=/path/to/recipes/ config_name=my_recipe.yaml save_path=/other/recipes/dir/my_complete_recipe.yaml
 -> saves the complete receip in /other/recipes/dir/my_complete_recipe.yaml

@BloodAxe
Copy link
Collaborator

Maybe add a unit test to export some recipes to ensure everything is working as it should?

@shaydeci
Copy link
Collaborator Author

Maybe add a unit test to export some recipes to ensure everything is working as it should?

Moved the logic to a helper method, which is whats tested in the added tests.

Louis-Dupont
Louis-Dupont reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we "communicate" about this ?
Ideally, it would be great if we mention this script somewhere, but I'm not sure where.
Maybe in Recipes_Training.md or Recipes_Custom.md ?

Louis-Dupont
Louis-Dupont previously approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci
Merge remote-tracking branch 'origin/master' into feature/SG-1179_uni…
6276b08 
…fy_recipe_script

# Conflicts:
#	tests/deci_core_unit_test_suite_runner.py
#	tests/unit_tests/__init__.py
BloodAxe
BloodAxe previously approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BloodAxe
BloodAxe approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit 20ddf3d into master Oct 31, 2023
7 checks passed
@shaydeci shaydeci deleted the feature/SG-1179_unify_recipe_script branch October 31, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe approved these changes

@Louis-Dupont Louis-Dupont Louis-Dupont left review comments

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shaydeci @BloodAxe @Louis-Dupont