Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ONNX Graph/ Compatibily GAP9 SDK #1556

Closed
wants to merge 1 commit into from
Closed

Simplify ONNX Graph/ Compatibily GAP9 SDK #1556

wants to merge 1 commit into from

Conversation

pbonazzi
Copy link

I have just simplified the ONNX Graph
Some Hardware Accellerator (like GAP9) don't support Neg operations.

now
previous

Referenced here:
#1555

@pbonazzi
Copy link
Author

Basically instead of doing Neg + Add, I recommend using Sub

@BloodAxe
Copy link
Collaborator

BloodAxe commented Oct 19, 2023

Thanks for your contribution @pbonazzi ! Overall it looks good to be accepted.

However our policy requires all commits in PR should be signed.
Please follow https://github.com/Deci-AI/super-gradients/blob/master/CONTRIBUTING.md to setup PGP key and how to update existing PR with signed commits.
Once once we would be happy with accepting it.

@BloodAxe
Copy link
Collaborator

Superseded by #1584

@BloodAxe BloodAxe closed this Oct 29, 2023
@pbonazzi
Copy link
Author

Thank you LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants