Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos and adding extra info to CONTRIBUTING #1546

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

hakuryuu96
Copy link
Contributor

Hi all!

This is my first time opening a pull request to this project, I just got acquainted with how to make signed commits.
I suggested that it would be great to go through the file and propose some changes in places that seemed not obvious to me while following the instructions (just to make it look tidier).

Changes:

  1. Fixed quotes in Jupyter Notebook section
  2. Replaced the explicit key example with a placeholder for it
  3. Added "making signed commit" and "gpg debug" sections (encountered ones ;) )

Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 096cb0e into Deci-AI:master Oct 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants