Fix serialization of ListConfig in checkpoint state dictionary #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ListConfig and silently serialized to state dict with pickle. By adding explicit casting to primitive tuple type we fix that
BloodAxe
requested review from
shaydeci,
ofrimasad and
Louis-Dupont
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating Processing instances some arguments may be not Tuple but ListConfig (Coming from transforms) and then they silently serialized to state dict with pickle. By adding explicit casting to primitive tuple type we fix that.
The problem with ListConfig in state dict is when unpickled, it forces import of super_gradients.
E.g
torch.load(yolo nas checkpoint)line would import SG, create logger and all that unexpected stuff.