Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/sg 000 fix integration test #1525

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Conversation

BloodAxe
Copy link
Collaborator

No description provided.

…eckpoints_dir_path inside trainer (Fixed by using tmp dir instead)

This should be investigated, however testing correctness of initialization of checkpoints_dir_path is not in the scope of this test.
…eds investigation) but for sake of having a release on time - let's just raise the tolerance bar
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit f421bc2 into master Oct 13, 2023
7 checks passed
@BloodAxe BloodAxe deleted the hotfix/SG-000-fix-integration-test branch October 13, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants