Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset & Visualization callback #1520

Merged

Conversation

BloodAxe
Copy link
Collaborator

New dataset class for COCO/CrowdPose
Visualization callback for pose estimation
Dataset params for COCO & Crowdpose datasets

BloodAxe and others added 30 commits October 2, 2023 16:14
…lease' into feature/SG-1060-yolo-nas-pose-release
# Conflicts:
#	src/super_gradients/recipes/dataset_params/coco_pose_estimation_dataset_params.yaml
…1506)

* Cherry pick changes to post-prediction, visualization and metric

* Remove unwanted references to new datasets

* Remove YoloNASPoseCollateFN

* Fixed unit test

* Improve clarify of bbox format by giving it more explicit name and added a bunch of docstrings

* Improve variable names
Louis-Dupont
Louis-Dupont previously approved these changes Oct 13, 2023
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feature/SG-1060-yolo-nas-pose-release-add-model-and-loss to master October 13, 2023 08:31
@BloodAxe BloodAxe dismissed Louis-Dupont’s stale review October 13, 2023 08:31

The base branch was changed.

…set-and-callback

# Conflicts:
#	src/super_gradients/module_interfaces/usage_instructions.py
#	src/super_gradients/training/datasets/pose_estimation_datasets/yolo_nas_pose_collate_fn.py
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
Maybe we can make the yamls smaller (looks like redundant overrides)
Some comment inline

Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 0c27404 into master Oct 13, 2023
6 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1060-yolo-nas-pose-release-dataset-and-callback branch October 13, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants