-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset & Visualization callback #1520
Dataset & Visualization callback #1520
Conversation
…lease' into feature/SG-1060-yolo-nas-pose-release
# Conflicts: # src/super_gradients/recipes/dataset_params/coco_pose_estimation_dataset_params.yaml
…1506) * Cherry pick changes to post-prediction, visualization and metric * Remove unwanted references to new datasets * Remove YoloNASPoseCollateFN * Fixed unit test * Improve clarify of bbox format by giving it more explicit name and added a bunch of docstrings * Improve variable names
…s' into feature/SG-1060-yolo-nas-pose-release-dataset-and-callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…set-and-callback # Conflicts: # src/super_gradients/module_interfaces/usage_instructions.py # src/super_gradients/training/datasets/pose_estimation_datasets/yolo_nas_pose_collate_fn.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Maybe we can make the yamls smaller (looks like redundant overrides)
Some comment inline
src/super_gradients/recipes/dataset_params/coco_pose_estimation_yolo_nas_dataset_params.yaml
Show resolved
Hide resolved
src/super_gradients/recipes/dataset_params/coco_pose_estimation_yolo_nas_dataset_params.yaml
Show resolved
Hide resolved
src/super_gradients/recipes/dataset_params/coco_pose_estimation_yolo_nas_dataset_params.yaml
Show resolved
Hide resolved
src/super_gradients/recipes/dataset_params/coco_pose_estimation_yolo_nas_dataset_params.yaml
Show resolved
Hide resolved
src/super_gradients/training/datasets/pose_estimation_datasets/coco_pose_estimation_dataset.py
Show resolved
Hide resolved
src/super_gradients/training/datasets/pose_estimation_datasets/coco_pose_estimation_dataset.py
Show resolved
Hide resolved
src/super_gradients/training/datasets/pose_estimation_datasets/coco_pose_estimation_dataset.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/datasets/pose_estimation_datasets/coco_pose_estimation_dataset.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/datasets/pose_estimation_datasets/coco_pose_estimation_dataset.py
Show resolved
Hide resolved
src/super_gradients/training/datasets/pose_estimation_datasets/coco_pose_estimation_dataset.py
Show resolved
Hide resolved
…d TypeFactory to resolve enum type
…set-and-callback # Conflicts: # src/super_gradients/training/datasets/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
New dataset class for COCO/CrowdPose
Visualization callback for pose estimation
Dataset params for COCO & Crowdpose datasets