ExtremeBatchCaseVisualizationCallback now has access to additional_batch_items #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BloodAxe
requested review from
shaydeci,
ofrimasad and
Louis-Dupont
as code owners
Louis-Dupont
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ExtremeBatchCaseVisualizationCallback will also store additional_batch_items for extreme batch.
Why
For pose estimation we cannot rely on
targetsto visualize groundtruth (DEKR & YoloNAS has completely different targets format). In contrast we can easily get groundtruth data directly fromadditional_batch_items.How
Since we also don't want to rely on specific keys from this dictionary, I thought it make sense to store
additional_batch_itemsas is in thecontext. This way we can refer to theadditional_batch_itemsas a whole and also not break existing metrics that rely on upacking this dict into context.