Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/sg 000 fix sigmas #1503

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Hotfix/sg 000 fix sigmas #1503

merged 5 commits into from
Oct 5, 2023

Conversation

BloodAxe
Copy link
Collaborator

@BloodAxe BloodAxe commented Oct 5, 2023

Though it is a right thing to do as a standalone PR.

  1. Fixes OKS sigmas for COCO dataset in all places
  2. Simplify YAML files (Avoid duplication of skeleton definition across multiple files)

Tested that integration accuracy test for DEKR is still passing (If the fixes sigma did affect the score the change was less than 0.05)

Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 307f7bd into master Oct 5, 2023
8 checks passed
@BloodAxe BloodAxe deleted the hotfix/SG-000-fix-sigmas branch October 5, 2023 11:37
BloodAxe added a commit that referenced this pull request Oct 5, 2023
* Fixed a bug where OKS sigmas had two incorrect values

* Fixed a bug where OKS sigmas had two incorrect values

* Allow user setting the SUPER_GRADIENTS_COCO_DATASET_DIR env variable to run test without need to edit path location by hand

* Remove excess stuff

(cherry picked from commit 307f7bd)
BloodAxe added a commit that referenced this pull request Oct 5, 2023
* Fixed a bug where OKS sigmas had two incorrect values

* Fixed a bug where OKS sigmas had two incorrect values

* Allow user setting the SUPER_GRADIENTS_COCO_DATASET_DIR env variable to run test without need to edit path location by hand

* Remove excess stuff

(cherry picked from commit 307f7bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants