Improve extreme batch visualization callbacks #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BloodAxe
commented
Sep 25, 2023
BloodAxe
commented
- Allow user to control whether to run on train and/or validation loaders
- Allow to control maximum number of logged images
- Store extreme batch on CPU
- OD visualization of batches changed to render side-by-side (pred-gt) images per image (This is mainly to allow easy understanding in W&B since old implementation was showing whole plot of GT batch first, then you had to scroll down to see Pred batch and go up and down to compare prediction for certain sample => not convinient)
BloodAxe
requested review from
shaydeci,
ofrimasad and
Louis-Dupont
as code owners
Louis-Dupont
previously approved these changes
Sep 26, 2023
There was a problem hiding this comment.
LGTM, just 1 small doc note. But I think it would be nice having @shaydeci having a look since he wrote the original code he might have deeper insights.
shaydeci
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Not quite sure why we moved to channels last...
Did we check everything works well with WandB and default SG Logger and pictures make sense?
Also, would be great if you can add additional tests covering the train loader end cases in our tests.unit_tests.extreme_batch_cb_test.ExtremeBatchSanityTest test
…d return type and layout (channels last) of the image tensor for visualization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.