Redirect logs based on env var #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnccd
requested review from
shaydeci,
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
There was a problem hiding this comment.
Good point, thanks for improving that!
I left a small comment, if you can have a look
Concerning the non-commercial use license, it is only for YOLONAS pre-trained weights.
All the code, but also other models pre-trained weights are under the Apache License.
BloodAxe
reviewed
Sep 20, 2023
|
@jnccd looks like your PR contains unsigned commits. Can you please fix that (instruction) and then we would be happy to continue merging your PR. |
Louis-Dupont
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
LGTM, just as @BloodAxe said if you can fix the signed commit issue
|
I overread that I needed to verify my commits, but I followed the instructions and force pushed the verified squashed commit 👍 |
BloodAxe
pushed a commit
that referenced
this pull request
Oct 3, 2023
(cherry picked from commit 8798744)
BloodAxe
added a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1455
This works fine based on local tests.
I also read the Licenses.
From my understanding the LICENSE.YOLONAS.md only refers to the model itself and code close to it and not the entire repo, but feel free to correct me.