Fixed loading preprocessing params from pretrained weights #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BloodAxe
requested review from
shaydeci,
ofrimasad and
Louis-Dupont
as code owners
Louis-Dupont
previously approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Looks great, just left 2 non-blocking comments, you can always ignore them.
About the tests, is it possible to set pretrained_weights to be a local path ? I never tried and need to dig into the code to check, but maybe it would work ?
In that case we can just quickly train a model locally and use its checkpoint path
|
@Louis-Dupont I've added the test that saves a temporary checkpoint with preprocessing params and then ensures that predict() works as expected. |
BloodAxe
added a commit
that referenced
this pull request
Sep 20, 2023
* Fixed loading preprocessing params from pretrained weights * Added support for file:/// in pretrained weights * Added test to ensure we load preprocessing params (cherry picked from commit 96df027)
BloodAxe
added a commit
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pretrained weights checkpoint contains preprocessing params ensures that it is properly loaded.