Remove __target__ for Detection CollateFN #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louis-Dupont
requested review from
shaydeci,
ofrimasad and
BloodAxe
as code owners
BloodAxe
reviewed
Sep 21, 2023
|
@Louis-Dupont one issue with missing |
@BloodAxe Done |
|
LGTM with me, what do we do with breaking change test? |
Louis-Dupont
deleted the
hotfix/SG-000-remove___target___for_collate_fn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
__target__when we actually already register these objectsWhy now ?
__target__in favor of Factory will make the PR look much simpler.Update
Moving all the utils functions to
utils/modulesubpackage, with 1 module per collate function