Feature/sg optional progressbar prediction

[EduardoPach]

What does this PR do:

Adds functionality mentioned in #1329

[EduardoPach]

@Louis-Dupont can you review it?

[BloodAxe]

Thanks for your PR. Unfortunately it look like it contains unsigned commits with is a hard requirement. Please check https://github.com/Deci-AI/super-gradients/blob/master/CONTRIBUTING.md for information on setting up the signed commits.

[EduardoPach]

Thanks for your PR. Unfortunately it look like it contains unsigned commits with is a hard requirement. Please check https://github.com/Deci-AI/super-gradients/blob/master/CONTRIBUTING.md for information on setting up the signed commits.

Oh, I didn't notice this before, sorry. I actually set it up the gpg key, but I've used the wrong e-mail adresse. Do you know if there's an easy way to verify the commits I did or should I open a new PR with the verified commits?

[BloodAxe]

No. What you need to do is create another branch starting from master, then move your commits from PR branch to the
new branch and force push it to the remote under the old name. Let's say your PR branch named 'feature/my_awesome_pr'
then you need to do the following:

git checkout master
git checkout -b feature/my_awesome_pr_signed
git merge --squash --no-commit feature/my_awesome_pr
git commit -S -m "My signed commit"
git push -f origin feature/my_awesome_pr_signed:feature/my_awesome_pr

Last command will overwrite your PR branch with the new signed commit containing all changes from the PR.

LMK if this snippet would work (written from memory). If yes, we will update contribution guide to contain this text to help other contributors (Btw, if it works feel free to make a second PR with these instructions).

[EduardoPach]

No. What you need to do is create another branch starting from master, then move your commits from PR branch to the new branch and force push it to the remote under the old name. Let's say your PR branch named 'feature/my_awesome_pr' then you need to do the following:

git checkout master
git checkout -b feature/my_awesome_pr_signed
git merge --squash --no-commit feature/my_awesome_pr
git commit -S -m "My signed commit"
git push -f origin feature/my_awesome_pr_signed:feature/my_awesome_pr

Last command will overwrite your PR branch with the new signed commit containing all changes from the PR.

LMK if this snippet would work (written from memory). If yes, we will update contribution guide to contain this text to help other contributors (Btw, if it works feel free to make a second PR with these instructions).

It seemed to work! I'll update the CONTRIBUTING.md shortly

[BloodAxe]

Glad it helped. Regarding PR to contributing md - probably no need, there is already one made by me #1486 :)

[BloodAxe]

#1465 (comment)

[EduardoPach]

#1465 (comment)

Sorry for the delay, gonna fix this right now

[BloodAxe]

@EduardoPach there is still some leftovers remaining. I left some comments for you to address.

[EduardoPach]

@BloodAxe Now I believe should be done!

[BloodAxe]

LGTM

[BloodAxe]

@EduardoPach I think we are ready to merge your PR, however i still see some non-signed commits present in this PR, like this one.
Can you please fix this and we can finally merge it )

[EduardoPach]

@EduardoPach I think we are ready to merge your PR, however i still see some non-signed commits present in this PR, like this one. Can you please fix this and we can finally merge it )

Fixed!

[BloodAxe]

Closing as stale