Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Exception when metric_to_watch is wrong #1437

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Improve Exception when metric_to_watch is wrong #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a309101
fix
Louis-Dupont Aug 31, 2023
5d01afa
update
Louis-Dupont Aug 31, 2023
a3d3221
Merge branch 'master' into hotfix/SG-000-improve_metric_to_watch_inde…
Louis-Dupont Aug 31, 2023
ba708e2
improve phrasing
Louis-Dupont Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/super_gradients/training/sg_trainer/sg_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,11 +557,15 @@ def _init_monitored_items(self):

# make sure the metric_to_watch is an exact match
metric_titles = self.loss_logging_items_names + get_metrics_titles(self.valid_metrics)
metric_to_watch_idx = fuzzy_idx_in_list(self.metric_to_watch, metric_titles)
try:
metric_to_watch_idx = fuzzy_idx_in_list(self.metric_to_watch, metric_titles)
except IndexError:
raise ValueError(f"No match found for `metric_to_watch={self.metric_to_watch}`. Available metrics to monitor are: `{metric_titles}`.")

metric_to_watch = metric_titles[metric_to_watch_idx]
if metric_to_watch != self.metric_to_watch:
logger.warning(
f"No exact match found for `metric_to_watch={self.metric_to_watch}`. It should be one of {metric_titles}. \n"
f"No exact match found for `metric_to_watch={self.metric_to_watch}`. Available metrics to monitor are: `{metric_titles}`. \n"
f"`metric_to_watch={metric_to_watch} will be used instead.`"
)
self.metric_to_watch = metric_to_watch
Expand Down
7 changes: 6 additions & 1 deletion src/super_gradients/training/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,12 @@ def fuzzy_idx_in_list(name: str, lst: List[str]) -> int:
:param lst: List[str], the list as described above.
:return: int, index of name in lst in the matter discussed above.
"""
return [fuzzy_str(x) for x in lst].index(fuzzy_str(name))
fuzzy_name = fuzzy_str(name)
fuzzy_list = [fuzzy_str(x) for x in lst]
if fuzzy_name in fuzzy_list:
return fuzzy_list.index(fuzzy_name)
else:
raise IndexError(f"Value `{name}` not found in the list `{lst}`. Please check the spelling.")


def get_param(params, name, default_val=None):
Expand Down