Hotfix/sg 000 fix predict loading from np torch #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louis-Dupont
requested review from
shaydeci,
ofrimasad and
BloodAxe
as code owners
BloodAxe
requested changes
Aug 28, 2023
There was a problem hiding this comment.
This PR seems to be extending scope of supported input types that predict function supports. However no documentation reflecting this pretty serious change is updated. I think it must be explicitly stated in docs what is the expected (or supported) dtypes for predict() function can be and what will happen if one pass HWC/CHW/BHWC/BCHW inputs there.
Also see my inline comment for load_image.
BloodAxe
reviewed
Aug 28, 2023
BloodAxe
reviewed
Aug 28, 2023
BloodAxe
reviewed
Aug 28, 2023
|
don;'t forget to PR master320 branch too |
…load_image method to get rid of hard-coded number of input channels
shaydeci
reviewed
Sep 19, 2023
BloodAxe
approved these changes
Sep 19, 2023
BloodAxe
deleted the
hotfix/SG-000-fix_predict_loading_from_np_torch
branch
BloodAxe
pushed a commit
that referenced
this pull request
Sep 19, 2023
* fix * Added table with all supported input types to predict() and improved load_image method to get rid of hard-coded number of input channels * Improve spelling * Improve type alias --------- Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com> Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com> (cherry picked from commit 4536d2d)
BloodAxe
added a commit
that referenced
this pull request
Sep 19, 2023
* fix * Added table with all supported input types to predict() and improved load_image method to get rid of hard-coded number of input channels * Improve spelling * Improve type alias --------- Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com> Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com> (cherry picked from commit 4536d2d) Co-authored-by: Louis-Dupont <35190946+Louis-Dupont@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue raised:
model.predictimplicitely expected (H, W, C) images.