Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export API fix: Raise meaningful exception if model has no preprocessing metadata but preprocessing=True #1413

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Export API fix: Raise meaningful exception if model has no preprocessing metadata but preprocessing=True #1413

merged 1 commit into from
Aug 24, 2023

Conversation

BloodAxe
Copy link
Collaborator

No description provided.

Louis-Dupont
Louis-Dupont approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit fc6ce60 into master_320 Aug 24, 2023
4 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1109-check-preprocessing branch August 24, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Louis-Dupont Louis-Dupont Louis-Dupont approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci shaydeci is a code owner

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BloodAxe @Louis-Dupont