Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 1106 Minor fixes in export api #1412

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

BloodAxe
Copy link
Collaborator

A bunch of small updates in many places

  • Fix type annotation for quantization mode

  • Ensure topk is not exceeding the actual number of predictions

  • Fix snippet text (numpy.zeros should take input shape as tuple)

  • Fix ONNX inference session in snippet to include backends

  • Fix float64 numbers YOLO-NAS generate float64 constants after export to ONNX

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
had a small question, but you can merge

@BloodAxe BloodAxe merged commit 737c5a5 into master_320 Aug 24, 2023
4 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1106-improve-export-api branch August 24, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants