Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 1039 add factory doc #1395

Merged
merged 13 commits into from
Aug 23, 2023
Merged

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Aug 20, 2023

Goal: Clarify what are factories and how to use them

@Louis-Dupont Louis-Dupont marked this pull request as ready for review August 21, 2023 09:06
Copy link
Contributor

@dafna-r dafna-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo corrections

documentation/source/factories.md Outdated Show resolved Hide resolved
documentation/source/factories.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 54e5a23 into master Aug 23, 2023
8 checks passed
@ofrimasad ofrimasad deleted the feature/SG-1039-add_factory_doc branch August 23, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants