Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc #1381

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Update doc #1381

merged 7 commits into from
Aug 22, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Aug 17, 2023 •
edited
Loading

Ticket was:

Add explanation about the context object:
The context concept in unclear and we need to explain what is it.

I mainly

  • Reorganized some parts to make each section clearer
  • Added Context attributes explicitly
  • Changed some minor phrasing

@Louis-Dupont Louis-Dupont marked this pull request as ready for review August 17, 2023 09:34
@Louis-Dupont
Copy link
Contributor Author

@eran-deci I updated according to your notes 2927314

@eran-deci
Copy link
Contributor

LGTM

BloodAxe
BloodAxe approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit 7b182ff into master Aug 22, 2023
7 checks passed
@Louis-Dupont Louis-Dupont deleted the feature/SG-1050-add_context_desc branch August 22, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci shaydeci is a code owner

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Louis-Dupont @eran-deci @BloodAxe