Feature/sg 1057 add breaking change tests #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Dupont <louis-dupont@live.fr>
ofrimasad
reviewed
Aug 20, 2023
|
I moved the test to a new CI "check". As you can see in the screenshot, the breaking change test is separate from the regular build3.8 |
ofrimasad
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descritption
Adding automatic test that would detect breaking change, and adding it to CI.
This PR focused on the following breaking changes:
Let me know if you think another important type of breaking change is not covered and that we should add it
Breaking Change test
I created a branch to make sure the test indeed breaks the CI when a breaking change is introduced.
