Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 1059 fix ci #1350

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Feature/sg 1059 fix ci #1350

merged 6 commits into from
Aug 7, 2023

Conversation

BloodAxe
Copy link
Collaborator

@BloodAxe BloodAxe commented Aug 7, 2023

What this PR does

Ensures that we test againts a checkout copy of SG.
It first uninstall the (maybe) existing SG installation and do a development-install a checkouted copy.
This PR also adds an option to have --extra-index-url in requirements.txt (Would be necessary for export API PR)
Since we install the SG we also remove the unnecessary export PYTHONPATH=/home/circleci/super_gradients

Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit ef886cd into master Aug 7, 2023
6 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1059-fix-CI branch August 7, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants