Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OD docs with clarified output formats #1348

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Update OD docs with clarified output formats #1348

merged 6 commits into from
Aug 7, 2023

Conversation

BloodAxe
Copy link
Collaborator

@BloodAxe BloodAxe commented Aug 7, 2023

No description provided.

@BloodAxe BloodAxe changed the title Update docs Update OD docs with clarified output formats Aug 7, 2023
shaydeci
shaydeci requested changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@shaydeci shaydeci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos and a repharsing request in line.

Also, maybe it would be nice to state that DetectionPostPredicionCallback and it's inheritors return XYXY.

documentation/source/ObjectDetection.md Outdated Show resolved Hide resolved
documentation/source/ObjectDetection.md Outdated Show resolved Hide resolved
documentation/source/ObjectDetection.md Outdated Show resolved Hide resolved
documentation/source/ObjectDetection.md Outdated Show resolved Hide resolved
documentation/source/ObjectDetection.md Outdated Show resolved Hide resolved
Louis-Dupont
Louis-Dupont previously approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wrote 2 small notes

documentation/source/ObjectDetection.md Outdated Show resolved Hide resolved
documentation/source/ObjectDetection.md Outdated Show resolved Hide resolved
shaydeci
shaydeci approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 3dd5919 into master Aug 7, 2023
7 checks passed
@BloodAxe BloodAxe deleted the feature/SG-854-update-od-docs branch August 7, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

@Louis-Dupont Louis-Dupont Louis-Dupont left review comments

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BloodAxe @Louis-Dupont @shaydeci