Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make classification models inherit from BaseClassifier #1314

Merged
merged 7 commits into from
Jul 31, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Jul 24, 2023

  • Setting inheritance of classification SgModule to BaseClassifier
  • Minor fix inside BaseClassifier: setting default values
  • Adding test

@Louis-Dupont Louis-Dupont changed the title Fix classification predict Make classification models inherit from BaseClassifier Jul 24, 2023
Signed-off-by: Louis Dupont <louis-dupont@live.fr>
Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit b8848d0 into master Jul 31, 2023
6 checks passed
@Louis-Dupont Louis-Dupont deleted the hotfix/SG-000-fix_classification_predict branch July 31, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants