Added explicit casting of input in predict pipeline. #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary if for some reason the input's preprocessing pipeline does not have normalization, so input stays in uint8 format.
This is necessary if for some reason the input's preprocessing pipeline does not have normalization, so input stays in uint8 format.
BloodAxe
requested review from
shaydeci,
ofrimasad and
Louis-Dupont
as code owners
This was referenced Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary if for some reason the input's preprocessing pipeline does not have normalization, so input stays in uint8 format.
Example:
Input image has [0..255] range for uint8 dtype
Validation dataset do not have normalization/standardization.
torch_inputs in this case would have torch.uint8 dtype and that would crash
Solution: Take the model's dtype of first parameter (That is likely to be the first layer taking the input) and cast input's dtype to this type.
Fixes: #1269