Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 946 simpify torch schedulers integration #1230

Merged

Conversation

shaydeci
Copy link
Collaborator

No description provided.

@shaydeci shaydeci marked this pull request as ready for review June 29, 2023 09:14
Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit e9a99ac into master Jul 5, 2023
7 checks passed
@ofrimasad ofrimasad deleted the feature/SG-946_simpligy_torch_schedulers_integration branch July 5, 2023 11:47
Louis-Dupont pushed a commit that referenced this pull request Jul 5, 2023
* test added

* docs added and cleanup

* docs finalized

* added unit test to suite

* added unit tests for all schedulers

* added warning for update_param_groups

* added clarification for phase arg

* refactored unt test

---------

Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
shaydeci added a commit that referenced this pull request Jul 10, 2023
* first draft

* improve text

* fix

* remove unwanted code

* wip

* wip

* add example

* remove unwanted change:

* improve display

* add test

* remove unwanted change

* add typing for mettrics

* undo unwanted change

* work with dict

* add tests

* Feature/sg 946 simpify torch schedulers integration (#1230)

* test added

* docs added and cleanup

* docs finalized

* added unit test to suite

* added unit tests for all schedulers

* added warning for update_param_groups

* added clarification for phase arg

* refactored unt test

---------

Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>

* add .

* add run_test_freq

* fix

* add optional

* fix

---------

Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants