Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default quantization params set in qat from config #1192

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

shaydeci
Copy link
Collaborator

Before the change, we accidentally rais a warning instead of warn.
Additinoally we did not set quantisation_params in cfg to be the default ones.

@shaydeci shaydeci marked this pull request as ready for review June 19, 2023 11:48
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 2ca8647 into master Jun 19, 2023
1 check passed
@ofrimasad ofrimasad deleted the feature/SG-956_use_default_quantization_params branch June 19, 2023 12:04
LHBuilder pushed a commit to LHBuilder/YOLO-NAS that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants